Skip to content

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.0 #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.0 #5478

wants to merge 2 commits into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 10, 2025

Bumps github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.23.0

2.23.0

Ginkgo 2.23.0 adds a handful of methods to GinkgoT() to make it compatible with the testing.TB interface in Go 1.24. GinkgoT().Context(), in particular, is a useful shorthand for generating a new context that will clean itself up in a DeferCleanup(). This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.

Features

  • bump to go 1.24.0 - support new testing.TB methods and add a test to cover testing.TB regressions [37a511b]

Fixes

  • fix edge case where build -o is pointing at an explicit file, not a directory [7556a86]
  • Fix binary paths when precompiling multiple suites. [4df06c6]

Maintenance

  • Fix: Correct Markdown list rendering in MIGRATING_TO_V2.md [cbcf39a]
  • docs: fix test workflow badge (#1512) [9b261ff]
  • Bump golang.org/x/net in /integration/_fixtures/version_mismatch_fixture (#1516) [00f19c8]
  • Bump golang.org/x/tools from 0.28.0 to 0.30.0 (#1515) [e98a4df]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#1504) [60cc4e2]
  • Bump github-pages from 231 to 232 in /docs (#1447) [fea6f2d]
  • Bump rexml from 3.2.8 to 3.3.9 in /docs (#1497) [31d7813]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#1501) [fc3bbd6]
  • Code linting (#1500) [aee0d56]
  • change interface{} to any (#1502) [809a710]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.23.0

Ginkgo 2.23.0 adds a handful of methods to GinkgoT() to make it compatible with the testing.TB interface in Go 1.24. GinkgoT().Context(), in particular, is a useful shorthand for generating a new context that will clean itself up in a DeferCleanup(). This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.

Features

  • bump to go 1.24.0 - support new testing.TB methods and add a test to cover testing.TB regressions [37a511b]

Fixes

  • fix edge case where build -o is pointing at an explicit file, not a directory [7556a86]
  • Fix binary paths when precompiling multiple suites. [4df06c6]

Maintenance

  • Fix: Correct Markdown list rendering in MIGRATING_TO_V2.md [cbcf39a]
  • docs: fix test workflow badge (#1512) [9b261ff]
  • Bump golang.org/x/net in /integration/_fixtures/version_mismatch_fixture (#1516) [00f19c8]
  • Bump golang.org/x/tools from 0.28.0 to 0.30.0 (#1515) [e98a4df]
  • Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#1504) [60cc4e2]
  • Bump github-pages from 231 to 232 in /docs (#1447) [fea6f2d]
  • Bump rexml from 3.2.8 to 3.3.9 in /docs (#1497) [31d7813]
  • Bump webrick from 1.8.1 to 1.9.1 in /docs (#1501) [fc3bbd6]
  • Code linting (#1500) [aee0d56]
  • change interface{} to any (#1502) [809a710]
Commits
  • 1d705bc v2.23.0
  • 37a511b bump to go 1.24.0 - support new testing.TB methods and add a test to cover te...
  • 7556a86 fix edge case where build -o is pointing at an explicit file, not a directory
  • 4df06c6 Fix binary paths when precompiling multiple suites.
  • cbcf39a Fix: Correct Markdown list rendering in MIGRATING_TO_V2.md
  • 9b261ff docs: fix test workflow badge (#1512)
  • 00f19c8 Bump golang.org/x/net in /integration/_fixtures/version_mismatch_fixture (#1516)
  • e98a4df Bump golang.org/x/tools from 0.28.0 to 0.30.0 (#1515)
  • 60cc4e2 Bump activesupport from 6.0.6.1 to 6.1.7.5 in /docs (#1504)
  • fea6f2d Bump github-pages from 231 to 232 in /docs (#1447)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
dependabot(deps): bump github.com/onsi/ginkgo/v2 from 2.22.2 to 2.23.0
a583771 
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.22.2 to 2.23.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.22.2...v2.23.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2025 •
edited
Loading

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e 052f766 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-capi-e2e 052f766 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e-aks 052f766 link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-ci-entrypoint 052f766 link true /test pull-cluster-api-provider-azure-ci-entrypoint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member

nawazkh commented Mar 10, 2025

We update go version as we merge CAPI. So lets stop this PR here until the base of CAPZ is upgraded to go 1.23.0
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 24, 2025

Superseded by #5504.

@dependabot dependabot bot closed this Mar 24, 2025
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.23.0 branch March 24, 2025 13:52
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@marosset marosset Awaiting requested review from marosset

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k8s-ci-robot @nawazkh